WWSTCERT-8138: Add support for frient Zigbee Range Extender #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 453 suites 0s ⏱️ Results for commit 099748e. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 099748e |
greens
reviewed
Sep 29, 2025
| end | ||
|
|
||
| local function do_refresh(driver, device) | ||
| device:send(Basic.attributes.ZCLVersion:read(device)) |
There was a problem hiding this comment.
this isn't being handled, so why does it need to be refreshed?
greens
changed the title
greens
reviewed
Sep 30, 2025
Comment on lines
+46
to
+47
| device:send(PowerConfiguration.attributes.BatteryVoltage:read(device)) | ||
| device:send(IASZone.attributes.ZoneStatus:read(device)) |
There was a problem hiding this comment.
Seems like the base driver's device:refresh should be enough here. I don't think you need to define a custom handler. A unit test would confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests