PIOT-252 add yanmi Y-K003-001 switch #2424
Conversation
|
Duplicate profile check: Warning - duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 456 suites 0s ⏱️ Results for commit a838c72. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a838c72 |
There was a problem hiding this comment.
this is a duplicate of the basic-switch profile
| return parent:get_child_by_parent_assigned_key(string.format("%02X", ep_id)) | ||
| end | ||
|
|
||
| local function create_child_devices(driver, device) |
There was a problem hiding this comment.
How many zigbee endpoints that support the On/Off cluster does this device have? It may be that you do not need a sub-driver at all, because of how the base driver handles this case: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-switch/src/init.lua#L104
There was a problem hiding this comment.
Currently, this switch has 3 endpoints. In the future, there will be 2-key and 1-key switches that will use this driver.
There was a problem hiding this comment.
as long as the zigbee endpoints report support for the On/Off cluster, they should still work with the base driver
There was a problem hiding this comment.
Because the labels generated by the base driver are not what I want.I hope that the endpoint of the switch will generate labels 1, 2, and 3 in sequence.
There was a problem hiding this comment.
There was a problem hiding this comment.
The label of the first endpoint of this driver is 2, not 1.
There was a problem hiding this comment.
But your base device's label is Yanmi Switch (3 Way) 1.multi-switch-no-master would create, Yanmi Switch (3 Way) 2 and Yanmi Switch (3 Way) 3 alongside the already existing Yanmi Switch (3 Way) 1. Am I misunderstanding? The code looks identical to me.
There was a problem hiding this comment.
I added a real device to the hub to test the multi-switch-no-master driver, and found that it was not like what you described.The label of the first endpoint of this driver is 2.Next are 3 and 4.
There was a problem hiding this comment.
Perhaps if you wrote some unit tests using expect_device_create I would understand more clearly.
There was a problem hiding this comment.
The problem has been solved due to an issue with the characters of the label.
greens
changed the title
thinkaName
force-pushed
the
yanmi-Y-K00x-001
branch
from
4855cbd to
96c4bd3
Compare
thinkaName
force-pushed
the
yanmi-Y-K00x-001
branch
from
96c4bd3 to
a838c72
Compare
2 participants
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests