CHAD-15777: temperatureMeasurement:temperature registering for native… #2267
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handlers for zwave and zigbee
|
|
|
Invitation URL: |
Test Results 68 files 446 suites 0s ⏱️ For more details on these errors, see this check. Results for commit b737c06. |
|
matter-sensor_coverage.xml
matter-switch_coverage.xml
zigbee-thermostat_coverage.xml
zwave-sensor_coverage.xml
zwave-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against b737c06 |
cjswedes
reviewed
Jul 17, 2025
| @@ -78,6 +78,9 @@ local function sensor_multilevel_report_handler(self, device, cmd) | |||
| local scale = 'C' | |||
| if (cmd.args.scale == SensorMultilevel.scale.temperature.FAHRENHEIT) then scale = 'F' end | |||
| device:emit_event(capabilities.temperatureMeasurement.temperature({value = cmd.args.sensor_value, unit = scale})) | |||
| if type(device.register_native_capability_attr_handler) == "function" then | |||
| device:register_native_capability_attr_handler("temperatureMeasurement","temperature") | |||
| end | |||
There was a problem hiding this comment.
typically I have avoided doing this in a subdriver even if I tested with it. Was this intended to be done or was it a part of testing?
There was a problem hiding this comment.
I threw this in there because I've seen it done a few times and this was the device that I used to develop the NH for Z-wave. This logic follows the default handler logic, but maybe a better route is to remove this method from the subdriver?
|
The |
| @@ -233,6 +233,9 @@ local function temperature_attr_handler(driver, device, ib, response) | |||
| local temp = measured_value / 100.0 | |||
| local unit = "C" | |||
| device:emit_event_for_endpoint(ib.endpoint_id, capabilities.temperatureMeasurement.temperature({value = temp, unit = unit})) | |||
| if type(device.register_native_capability_attr_handler) == "function" then | |||
There was a problem hiding this comment.
Will the same be done for matter-thermostat?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Change
Registering of native handlers for zigbee and z-wave devices for temperatureMeasurement capabilities using the default handlers.
Summary of Completed Tests