Fix #170 #171 #172 #173: boost for positions, TTL refresh event, lock… - #213
Merged
Conversation
…bs#173: boost for positions, TTL refresh event, lock event includes unlock_ledger, vesting admin getter
|
@devpeter999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for sdcontracts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #170, Fixes #171, Fixes #172,Fixes #173 — four issues across farming-pool, factory, and vesting-wallet contracts.
#170 — calculate_credits ignores boost allocation for Position-based staking
calculate_credits,checkpoint_position,get_user_position, andget_creditsnow apply boost allocation to Position-based staking viacompute_total_stake, matching the behavior already present in UserStake-based staking. Previously, Position-based users never received boost benefits.#171 — refresh_pool_ttls does not emit event for TTL refresh activity
refresh_pool_ttlsnow emits a("factory", "ttl_ref")event with(start_id, end)so operators can monitor TTL refresh activity off-chain.#172 — lock_assets event does not include unlock_ledger timestamp
The
("pool", "locked")event now includesposition.unlock_ledgerin its payload so off-chain indexers can display when users can withdraw.#173 — Vesting wallet has no get_admin function
Added a public
admin()getter to the vesting wallet so frontends can query the current admin address.