feat: resolve issues - #210
Merged
Merged
Conversation
…artDropLabs#157) Store the original funder address at initialization and use it instead of the current admin when returning unvested tokens on revocation. This ensures that if admin rights are transferred via transfer_admin before revoke is called, the tokens go back to the address that originally funded the vesting schedule.
…pLabs#158) Add doc comment explaining that migrate is a placeholder for future schema migrations, describing the intended pattern once real migrations are needed (match on old version, perform transforms, stamp new version).
…ropLabs#160) Maintain an ordered Vec<Address> of whitelisted users in instance storage, updated by add/remove/batch_add/batch_remove. Expose get_whitelisted_users(offset, limit) returning a paginated ListWhitelistedResponse so admins can audit the full whitelist on-chain.
…opLabs#161) Explain that credit_rate and global_multiplier are snapshotted per-user at checkpoint time, so users who checkpoint less frequently may earn credits at a different effective rate than those who checkpoint more often during a rate change window. Document this as an intentional design trade-off that keeps accrual local and avoids O(n) migration.
|
@0xSlink Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for sdcontracts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157 Revoke sends unvested tokens to current admin, not original funder Added DataKey::Funder storing the init-time admin; revoke now transfers unvested tokens to funder
Closes #158 migrate is undocumented no-op placeholder Added comprehensive doc comment explaining current no-op behavior and the pattern for future migrations
Closes #160 No way to list all whitelisted users Maintains a Vec
in instance storage; added get_whitelisted_users(offset, limit) with ListWhitelistedResponseCloses #161 Credit rate changes between checkpoints undocumented