feat: add rate limiting middleware to all API endpoints (#10) - #67
Merged
prodbycorne merged 2 commits intoJul 20, 2026
Merged
Conversation
Merged
3 tasks
boluwacodes
added a commit
to boluwacodes/smartdrop-backend
that referenced
this pull request
Jul 22, 2026
The merge of SmartDropLabs#67 (fix-10-api-rate-limiting) into main pasted the entire top of the file twice and, within the second copy, declared `airdrops` twice in module.exports so the later object-literal key silently dropped expiryCheckIntervalSeconds/ledgerCacheTtlMs/expiryScanBatchSize used by the airdrop expiry job. Broke `require('./config')` outright (duplicate `const` in the same scope), taking every test that touches config with it.
boluwacodes
added a commit
to boluwacodes/smartdrop-backend
that referenced
this pull request
Jul 22, 2026
Same bad-merge pattern as config.js: the whole file was pasted twice. Kept the newer body (health checks, price-source circuit state, airdrop expiry job wiring) and restored the API rate-limiting middleware mounts from the older copy, since that wiring is the actual feature SmartDropLabs#67 was merging in and would otherwise have been lost.
boluwacodes
added a commit
to boluwacodes/smartdrop-backend
that referenced
this pull request
Jul 22, 2026
Same duplicated-file pattern; merged the two copies (keeping the PAYLOAD_TOO_LARGE coverage added by the newer copy) and fixed the RATE_LIMITED assertion to include retry_after_seconds, matching what src/middleware/rateLimit.js actually returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
GrantFox OSS campaign — smart escrow payout on merge.