Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions workflow to notify extension managers when there are errors or warnings #1984

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vkt1414
Copy link

@vkt1414 vkt1414 commented Nov 18, 2023

This workflow does not interfere if an extension already has a point of contact. However, it will automatically check for new extensions that do not have a CODEOWNER. Whether you choose to commit the updated CODEOWNERS back to the repo when an extension lacks a CODEOWNER is entirely up to you. I can add another step to the workflow to accommodate this.

If there is a GitHub issue created for an extension already, I do not update it. Should we? I do not know if some extensions are maintained anymore, so we will have a long thread if errors or warnings are not addressed promptly. Do you think, updating an issue with up to 5 consecutive days of builds (with errors or warnings) using comments will be a good idea?

Please note that a limitation of this workflow is that non-GitHub repositories cannot be notified.

Take a look at issues created and closed by GitHub actions bot in my fork. https://github.com/vkt1414/ExtensionsIndex/issues

Looking forward to your feedback.

Thanks to @jcfr @fedorov @pieper for guidance.

Copy of Decision Tree Diagram by Slidesgo (1)

@vkt1414 vkt1414 marked this pull request as ready for review November 18, 2023 22:51
@lassoan
Copy link
Contributor

lassoan commented Dec 3, 2024

This is really good! Ability to check extension builds and notify developers could be really useful. CDash can send emails if maintainers sign up on CDash, but submitting an issue is more visible.

  • Is the issue going to be submitted into each extension's issue tracker? (it should be)
  • As a start, we should only report regressions (any new test failures)
  • We could add a "maintainer" field to the extension description json file (maybe we could require it for tier 3 and above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants