Skip to content

don't save equipment async on game close #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AzureAaron merged 1 commit into from
Mar 25, 2026
Merged

don't save equipment async on game close #2264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockInventoryScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class SkyblockInventoryScreen extends InventoryScreen implements HoveredI
private static final Path FOLDER = SkyblockerMod.CONFIG_DIR.resolve("equipment");

private final Slot[] equipmentSlots = new Slot[4];
private ItemStack hoveredItem;
private @Nullable ItemStack hoveredItem;

private static void save(String profileId) {
try {
Expand Down Expand Up @@ -116,9 +116,7 @@ public static void initEquipment() {

ClientLifecycleEvents.CLIENT_STOPPING.register(client1 -> {
String profileId = Utils.getProfileId();
if (!profileId.isBlank()) {
CompletableFuture.runAsync(() -> save(profileId), Executors.newVirtualThreadPerTaskExecutor());
}
if (!profileId.isBlank()) save(profileId);
});
}

Expand Down
Loading