Remove expired hoppity eggs on lobby join#2246
Open
WilliamTTran wants to merge 2 commits intoSkyblockerMod:masterfrom
Open
Remove expired hoppity eggs on lobby join#2246WilliamTTran wants to merge 2 commits intoSkyblockerMod:masterfrom
WilliamTTran wants to merge 2 commits intoSkyblockerMod:masterfrom
Conversation
AzureAaron
previously approved these changes
Mar 18, 2026
Alex33856
previously requested changes
Mar 19, 2026
src/main/java/de/hysky/skyblocker/skyblock/chocolatefactory/EggFinder.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully finally fixes the last scenario where this issue can happen: #2061
The websocket's initial message can contain stale egg locations from a previous cycle if no player has found the new egg yet or if the server sends a message that contains an expired egg by the time it is received by the player. Filters these out using the expirationEpoch field already provided by the server. Anyone already in the lobby as an egg despawns should already see the correct behavior due to the hourly check/reset.
Changes:
Testing: This is god awful to recreate in game so mock testing only