Skip to content

Remove expired hoppity eggs on lobby join#2246

Open
WilliamTTran wants to merge 2 commits intoSkyblockerMod:masterfrom
WilliamTTran:ghost-egg-fix
Open

Remove expired hoppity eggs on lobby join#2246
WilliamTTran wants to merge 2 commits intoSkyblockerMod:masterfrom
WilliamTTran:ghost-egg-fix

Conversation

@WilliamTTran
Copy link
Contributor

Hopefully finally fixes the last scenario where this issue can happen: #2061

The websocket's initial message can contain stale egg locations from a previous cycle if no player has found the new egg yet or if the server sends a message that contains an expired egg by the time it is received by the player. Filters these out using the expirationEpoch field already provided by the server. Anyone already in the lobby as an egg despawns should already see the correct behavior due to the hourly check/reset.

Changes:

  • Added expirationEpoch field to EggWaypointMessage
  • Filter out expired eggs from INITIAL_MESSAGE on lobby join

Testing: This is god awful to recreate in game so mock testing only

  • Confirmed expirationEpoch is correctly parsed and all 6 eggs receive valid future expiration times on join
  • Filter logic verified correct via log output showing current time vs expiration diffs

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Mar 16, 2026
@AzureAaron AzureAaron added the bug Something isn't working label Mar 18, 2026
@AzureAaron AzureAaron added this to the 6.2.0 milestone Mar 18, 2026
AzureAaron
AzureAaron previously approved these changes Mar 18, 2026
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Mar 18, 2026
@AzureAaron AzureAaron requested a review from Alex33856 March 18, 2026 18:20
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed merge me please Pull requests that are ready to merge labels Mar 19, 2026
@Alex33856 Alex33856 requested a review from AzureAaron March 22, 2026 20:56
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants