Fix Various Craft Price Tooltip Issues#2230
Merged
AzureAaron merged 3 commits intoSkyblockerMod:masterfrom Mar 16, 2026
Merged
Conversation
Contributor
Alex33856
commented
Mar 14, 2026
Alex33856
commented
- Fix not accounting NPC shop recipes
- Fix not accounting for coin costs in recipes
- Fix using 0 coin recipes for some items (mainly Rift items)
- Switch from ConcurrentHashMap to synchronized Object2DoubleOpenHashMap
- Fix two typos
AzureAaron
approved these changes
Mar 16, 2026
LifeIsAParadox
added
merge me please
Alex33856
added a commit
that referenced
this pull request
Mar 16, 2026
* Fix Craft Price Tooltip not accounting for NPC shop recipes * Fix not accounting for coins, and attempting to process empty ingredients * Various fixes (cherry picked from commit 4af4145)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.