Skip to content

Fix API Id for Renamed Enchanted Books #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AzureAaron merged 1 commit into from
Mar 16, 2026
Merged

Fix API Id for Renamed Enchanted Books #2221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/main/java/de/hysky/skyblocker/utils/EnchantedBookUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,34 @@
package de.hysky.skyblocker.utils;

import de.hysky.skyblocker.annotations.Init;
import it.unimi.dsi.fastutil.objects.Object2ObjectMaps;
import it.unimi.dsi.fastutil.objects.Object2ObjectOpenHashMap;
import net.minecraft.network.chat.Component;

import java.util.Locale;
import java.util.Map;

public final class EnchantedBookUtils {
private static final Map<String, String> API_ID_OVERRIDES = Object2ObjectMaps.synchronize(new Object2ObjectOpenHashMap<>());

@Init
public static void init() {
NEURepoManager.runAsyncAfterLoad(() -> {
API_ID_OVERRIDES.clear();
NEURepoManager.forEachItem(item -> {
String itemId = item.getSkyblockItemId();
if (!itemId.contains(";")) return;
if (!item.getMinecraftItemId().equals("minecraft:enchanted_book")) return;

String actualId = NEURepoManager.getConstants().getBazaarStocks().getBazaarStockOrDefault(itemId);
if (itemId.equals(actualId)) return; // not in bazaar stocks
String guessId = getApiIdByName(TextTransformer.fromLegacy(item.getLore().getFirst()));
if (guessId.equals(actualId)) return; // not renamed
API_ID_OVERRIDES.put(guessId, actualId);
});
});
}

public static String getApiIdByName(Component enchantName) {
String name = enchantName.getString().toUpperCase(Locale.ENGLISH);
name = name.replace("BUY ", "").replace("SELL ", "").replace("'", "").replace("-", "_");
Expand All @@ -15,6 +39,7 @@ public static String getApiIdByName(Component enchantName) {
parts[parts.length - 1] = String.valueOf(RomanNumerals.romanToDecimal(parts[parts.length - 1]));
}
boolean isUltimate = !enchantName.getSiblings().isEmpty() && enchantName.getSiblings().getLast().getStyle().isBold();
return "ENCHANTMENT_" + (isUltimate ? "ULTIMATE_" : "") + String.join("_", parts);
String id = "ENCHANTMENT_" + (isUltimate ? "ULTIMATE_" : "") + String.join("_", parts);
return API_ID_OVERRIDES.getOrDefault(id, id);
}
}
Loading