Skip to content

Auto-detect McGrubber stacks#2212

Open
LJNeon wants to merge 4 commits intoSkyblockerMod:mainfrom
LJNeon:mcgrubber-autodetect
Open

Auto-detect McGrubber stacks#2212
LJNeon wants to merge 4 commits intoSkyblockerMod:mainfrom
LJNeon:mcgrubber-autodetect

Conversation

@LJNeon
Copy link
Contributor

@LJNeon LJNeon commented Mar 7, 2026

Adds a new option (enabled by default) to auto-detect how many McGrubber Burgers the player owns in three different ways:

  1. From /sblevels
  2. From talking to the Motes Grubber
  3. When picking up an orb in the rift

This updates the existing stack count option, it doesn't cache the value elsewhere.

Would like to note that I have no experience with java or minecraft modding so a more in-depth review of the code is likely a good idea.

Testing

Tests for 1st detection method Set stack count to an incorrect value: image

Open consumble items in /sblevels:
image

Stack count is corrected:
image

Tests for 2nd detection method Set stack count to an incorrect value: image

Talk to the Motes Grubber:
image

Stack count is corrected:
image

Tests for 3rd detection method Set stack count to an incorrect value: image

Pick up an orb in the rift:
image

Stack count is corrected:
image

Enigma's Crib orbs don't cause any issues:
image

Tests to confirm disabling the option works Set stack count to an incorrect value & disable the auto-detect option: image

Talk to the Motes Grubber:
image

Stack count remains unchanged:
image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Mar 7, 2026
@LJNeon LJNeon force-pushed the mcgrubber-autodetect branch from d9a3356 to 5ab05af Compare March 19, 2026 16:07
@LJNeon LJNeon force-pushed the mcgrubber-autodetect branch from 5ab05af to e7a06a3 Compare March 22, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants