Open
Conversation
d9a3356 to
5ab05af
Compare
5ab05af to
e7a06a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option (enabled by default) to auto-detect how many McGrubber Burgers the player owns in three different ways:
This updates the existing stack count option, it doesn't cache the value elsewhere.
Would like to note that I have no experience with java or minecraft modding so a more in-depth review of the code is likely a good idea.
Testing
Tests for 1st detection method
Set stack count to an incorrect value:Open consumble items in

/sblevels:Stack count is corrected:

Tests for 2nd detection method
Set stack count to an incorrect value:Talk to the Motes Grubber:

Stack count is corrected:

Tests for 3rd detection method
Set stack count to an incorrect value:Pick up an orb in the rift:

Stack count is corrected:

Enigma's Crib orbs don't cause any issues:

Tests to confirm disabling the option works
Set stack count to an incorrect value & disable the auto-detect option:Talk to the Motes Grubber:

Stack count remains unchanged:
