Use proper deprecation warning for ExprNoDamageTicks #7890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
requested review from
Efnilite and
erenkarakal
and removed request for
a team
APickledWalrus
added
bug
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
approved these changes
May 22, 2025
sovdeeth
approved these changes
May 22, 2025
skriptlang-automation
bot
added
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ExprNoDamageTicks is deprecated, but it does not print a "proper" deprecation warning. Thus, it is not affected by suppressing those warnings. It also spams the tests a lot.
Solution
I switched to the proper method from ScriptWarning. The warning itself remains the same.
Testing Completed
I did suppress the warning for the existing test script and confirmed that it is no longer printed.
Supporting Information
n/a
Completes: none
Related: none