Use StopTrigger ExecutionIntent in EffExit when applicable #7889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
approved these changes
May 22, 2025
erenkarakal
approved these changes
May 22, 2025
skriptlang-automation
bot
added
patch-ready
UnderscoreTud
approved these changes
May 23, 2025
skriptlang-automation
bot
added
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EffExit currently uses the StopSections intent even for
stop trigger. While stopping all sections is technically correct, it is more accurate (and useful) to use the StopTrigger intent.Solution
Simply checks
outerSection == null(true only forstop trigger) and returns the appropriate intent.Testing Completed
No additional tests are needed/applicable.
Supporting Information
I planned to use ExecutionIntent in supporting local variable type hints. I ran into this issue.
Completes: none
Related: none