Skip to content

StructUsing Multiple #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev/feature
Choose a base branch
from

Conversation

Absolutionism
Copy link
Contributor

Description

This PR aims to allow users to provide multiple experiments/features in one line/instance of StructUsing


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested a review from a team as a code owner May 6, 2025 04:31
@Absolutionism Absolutionism requested review from Pesekjak and erenkarakal and removed request for a team May 6, 2025 04:31
@sovdeeth
Copy link
Member

sovdeeth commented May 6, 2025

I don't think this is a good idea. Experiment names could contain commas and I am not a fan of combining them to begin with. It's kind of a solution in search of a problem imo. I see no issue with one experiment per line, it's clear, it's not exactly hard for the user to write, and it mirrors import/directives in all other languages.

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. up for debate When the decision is yet to be debated on the issue in question labels May 6, 2025
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with sovde

@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. needs reviews A PR that needs additional reviews up for debate When the decision is yet to be debated on the issue in question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants