Literal Multiple Infos Warning #7851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
requested review from
UnderscoreTud and
Romitou
and removed request for
a team
sovdeeth
added
the
enhancement
sovdeeth
requested changes
May 6, 2025
sovdeeth
requested changes
May 12, 2025
src/main/java/ch/njol/skript/classes/registry/RegistryParser.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
May 13, 2025
sovdeeth
approved these changes
May 14, 2025
skriptlang-automation
bot
added
the
needs reviews
APickledWalrus
requested changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a warning when a literal, that can be referenced to multiple ClassInfos/types, is used.
The warning informs the user that the literal can be referenced to multiple types and that they should consider specifying which type to use, using the new literal specification feature introduced in 2.11.
This PR also fixes a bug that was present within
SkriptParser#parseSingleExprwhere when an element's pattern allowed multiple types, includingObjectfor an expression (%.../.../object%) if all other types failed to be parsed and reachedObject, it did not treat it correctly as seen with the prior condition check (if (exprInfo.classes[0].getC() == Object.class) {). Which lead to the literal being parsed as the firstClassInfothat gets registered with that pattern. Now the loop will log if it reachesObjectand continue to attempt every otherClassInfo. If all fail, andObjectwas logged, will use the method#getUnparsedLiteralwhich is the code from the aforementioned condition, to prevent duplicated code.With that change, a fix was required for
CondContainsas it did not properly handleUnparsedLiterals.Target Minecraft Versions: any
Requirements: none
Related Issues: none