Conversation
|
Thank you very much for your PR.
|
PhaseManager is now instance-based instead of static, improving encapsulation and usability. Equality and hashCode methods were removed from Phase, so phase equality is now by reference. Corresponding tests were updated to reflect these changes.
|
Thanks for the feedback, I agree both of those things should change. I updated those, as well as changed phase equality comparison to be based on reference instead of name. The documentation PR has been updated as well. |
|
Thanks for the update. But I have some new notes.
|
I want to a bit quick up the development time on this PR. So I will send a PR to your repo later today or tomorrow with the requested fixes and a bit more. |
|
Sounds good, sorry about the delay, was preparing for a competition. If you would like me to do any additional changes feel free to let me know. |
Don't worry, all good. Best of luck at your competition! |
|
Could you please check/approve the PR on your repository? |
|
Yep, sorry just saw the PR. I added some comments. Once we're done making changes, we'll need to update the documentation as well as I haven't done that. |
Adds a flexible phase management system for FTC match time periods. Includes:
Phaseclass for defining named time periods with configurable durations and time unitsPhaseManagerfor automatic phase transitions based on elapsed match time with listener callbacksAllows teams to easily structure autonomous and teleop logic around match phases with automatic time-based transitions.