Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend 32bit test coverage #1386

Closed
antonfirsov opened this issue Oct 15, 2020 · 4 comments
Closed

Extend 32bit test coverage #1386

antonfirsov opened this issue Oct 15, 2020 · 4 comments

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Oct 15, 2020

A follow up on #1378 (comment).

Currently 32 bit test execution is only done for .NET Framework, with dotnet xunit which is an obsolete tool today, we need to adapt dotnet test, and add 32 bit CI targets for both net5.0 and netcoreapp3.1. Opening an issue to remember and track this debt.

See:
https://twitter.com/tannergooding/status/1316755685938393089

@JimBobSquarePants
Copy link
Member

I've established that we can already use dotnet test on our Windows CI environments to run with 32bit coverage without xunit.

https://github.com/JimBobSquarePants/PlatformBuildTests/runs/1259919494

Doesn't work on Ubuntu.

@antonfirsov
Copy link
Member Author

Windows-only coverage is already much better, than no coverage :)

@JimBobSquarePants
Copy link
Member

I think we can close this now. We don't do any 32bit test runs

@antonfirsov
Copy link
Member Author

We don't do, but IMO we should. 32bit is still relevant and memory + runtime behavior is different there. Runtime deviations between 32bit and 64bit are less common these days, so no need to replicate all the configurations, but having at least one 32bit CI leg would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants