Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteExecutor does not work with 32bit .NET Framework #1661

Closed
antonfirsov opened this issue Jun 14, 2021 · 1 comment
Closed

RemoteExecutor does not work with 32bit .NET Framework #1661

antonfirsov opened this issue Jun 14, 2021 · 1 comment
Milestone

Comments

@antonfirsov
Copy link
Member

There is a leftover from #1376 / #1659, since RemoteExecutor does not work with dotnet xunit:

// RemoteExecutor does not work with "dotnet xunit" used to run tests on 32 bit .NET Framework:
// https://github.com/SixLabors/ImageSharp/blob/381dff8640b721a34b1227c970fcf6ad6c5e3e72/ci-test.ps1#L30
public static bool IsNot32BitNetFramework = !TestEnvironment.IsFramework || TestEnvironment.Is64BitProcess;
[ConditionalFact(nameof(IsNot32BitNetFramework))]
public void RemoteExecutor_FailingRemoteTestShouldFailLocalTest()

This means that RemoteExecutor/FeatureTestRunner test passes can be false positives on 32 bit .NET Framework. Ideally this should be addressed together with #1386 by replacing dotnet xunit with a local 32bit SDK installation + build + test run.

@JimBobSquarePants
Copy link
Member

We can close this now since we no longer support .NET Framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants