Image::rotate90() と関連するメンバ関数の性能を改善 #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ブロックサイズが最適かどうかは、しっかり調べていません。 |
|
v0.8 に組み込んでテストしたところ、Windows 版は 8, macOS (Apple Silicon) M2 は 16 が良さそうでした。 v0.8 への移植時には、マクロで 8 / 16 切り替えるようにしておきます。 |
|
調査ありがとうございます！ |
|
Merged. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1182 の実装の pull request です。
アクセス順の工夫（ブロック化）によるキャッシュの効率的な利用、および正方形画像に対する in-place 実装により、
Image::rotate90()、Image::rotated90()、Image::rotate270()、Image::rotated270()の実行時性能を改善しました。