Revert "feat: add search component with modal and results handling"#36
Revert "feat: add search component with modal and results handling"#36
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced client-side search feature (modal + results) and removes its Pagefind build/indexing integration from both the template and the root package.
Changes:
- Remove
Search.astro(modal-based search UI + inline Pagefind logic) and replace the header search area with a disabled “coming soon” input. - Remove Pagefind from dependencies and stop running
pagefind --site distduring builds. - Clean up lockfiles to drop Pagefind entries (and remove the template lockfile).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| template/src/components/Search.astro | Deleted the search modal/component and all Pagefind client logic. |
| template/src/components/Header.astro | Removes <Search /> usage; adds a disabled search input placeholder. |
| template/package.json | Removes Pagefind devDependency and Pagefind step from build script. |
| template/pnpm-lock.yaml | Removed the template lockfile (previously included Pagefind). |
| pnpm-lock.yaml | Removes Pagefind and related optional packages from the root lockfile. |
| package.json | Removes Pagefind dependency and Pagefind step from build script. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| disabled | ||
| title="Search coming soon" | ||
| class="w-40 lg:w-48 h-9 pl-3 pr-8 text-sm border-b border-gray-200 dark:border-gray-700 bg-transparent text-gray-900 dark:text-gray-100 placeholder:text-gray-400 dark:placeholder:text-gray-500 focus:outline-none focus:border-cyan-500 disabled:opacity-50 disabled:cursor-not-allowed" | ||
| /> | ||
| <iconify-icon icon="mdi:magnify" class="absolute right-2.5 top-1/2 -translate-y-1/2 text-gray-400 dark:text-gray-500" width="16" height="16"></iconify-icon> |
There was a problem hiding this comment.
The disabled search input relies on placeholder text only; without an associated or an aria-label/aria-labelledby, screen readers may announce it ambiguously (and placeholders aren’t a reliable label). Consider adding an accessible name (e.g., aria-label="Search") and marking the magnify icon as decorative (aria-hidden="true") if it shouldn’t be read aloud.
| disabled | |
| title="Search coming soon" | |
| class="w-40 lg:w-48 h-9 pl-3 pr-8 text-sm border-b border-gray-200 dark:border-gray-700 bg-transparent text-gray-900 dark:text-gray-100 placeholder:text-gray-400 dark:placeholder:text-gray-500 focus:outline-none focus:border-cyan-500 disabled:opacity-50 disabled:cursor-not-allowed" | |
| /> | |
| <iconify-icon icon="mdi:magnify" class="absolute right-2.5 top-1/2 -translate-y-1/2 text-gray-400 dark:text-gray-500" width="16" height="16"></iconify-icon> | |
| aria-label="Search" | |
| disabled | |
| title="Search coming soon" | |
| class="w-40 lg:w-48 h-9 pl-3 pr-8 text-sm border-b border-gray-200 dark:border-gray-700 bg-transparent text-gray-900 dark:text-gray-100 placeholder:text-gray-400 dark:placeholder:text-gray-500 focus:outline-none focus:border-cyan-500 disabled:opacity-50 disabled:cursor-not-allowed" | |
| /> | |
| <iconify-icon icon="mdi:magnify" class="absolute right-2.5 top-1/2 -translate-y-1/2 text-gray-400 dark:text-gray-500" width="16" height="16" aria-hidden="true"></iconify-icon> |
Reverts #35