This repository was archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] Fix client timers having invalid <1ds waits#1431
Open
SinguloBot wants to merge 2 commits intomasterfrom
Open
[MIRROR] Fix client timers having invalid <1ds waits#1431SinguloBot wants to merge 2 commits intomasterfrom
SinguloBot wants to merge 2 commits intomasterfrom
Conversation
Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: MrStonedOne <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#7598
About The Pull Request
Requested by Ike
Original PR: tgstation/tgstation#69356
Timers clamped their waits to >world.tick_lag and rounded it to multiples of the same, but this is invalid for clienttime timers. Clienttime timers have a resolution of one decisecond instead, so we now clamp and round it to that instead. (The stacktrace for negative waits is technically invalid but I didn't care enough to touch it.)
Why It's Good For The Game
These are effectively zero-wait timers, which can mess up the iteration of the clienttime timer queue by being inserted into the past or current tick's list and causing the head/index to desync, potentially leaving spent timers in the queue or firing them again.
Also requested by Ike
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Dejaku51, out-of-phaze, LemonInTheDark, MrStonedOne
code: Fix client timers having invalid <1ds waits
/:cl: