This repository was archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] [TG PORT] Removes Robot Commands and replaces it with an integrated control tablet program + silicons start with HUD on#1014
Open
SinguloBot wants to merge 2 commits intomasterfrom
Open
Conversation
…ontrol tablet program + silicons start with HUD on (#7351) * tgui: Borg tablets and RoboTact as a borg self-management app (#53373) * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * take one * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * part 2 * Automatic changelog compile [ci skip] * part 3 * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * part three I think * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * who even knows what step I'm on anymore * and another one * Automatic changelog compile [ci skip] * PR time * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Forward Progress * Automatic changelog compile [ci skip] * Merge remote-tracking branch 'upstream/master' into SiliScreen * more foward progress * RoboTact * bad tab * Improvements all around Plus some changes to vis_overlay to allow for color * Lights and things * borg network card borg tablets lose networking when borg is locked or has no power * hud changes not done yet, but getting close * better modPC screen button * updoot * more useful colors * linter * Do I finally get a green ✓ * better law sync catching * hate linters Co-authored-by: Changelogs <action@github.com> * Fixes borg light overlays (#61920) * Fixes cyborg light overlay not showing when the light is off (#64279) Borgs have a lightbulb overlay. The plane of the overlay depends on the status of the lights, so as to glow when on. The plane being used for disabled lights no longer shows above mobs for reasons I do not know. But this plane (-2) works. * Fixes a runtime with borg tablets when borgs get created. (#53953) * Fixes borg logs missing from Robotact (#56738) Apparently using <NtosWindow.Content scrollable> inside a section doesn't work anymore. This PR removes these tags from RoboTact and changes the <Section> tag to handle the scrolling instead, with the <Flex.Item> tag now handling the size of the area, allowing RoboTact to display logs once again. Closes #56494 * Borgs and AIs now start with their borgHUDs/siliconHUDs on by default (#51549) * Update silicon.dm * Update code/modules/mob/living/silicon/silicon.dm Co-authored-by: MrPerson <spamtaffic@gmail.com> * Update silicon.dm Co-authored-by: MrPerson <spamtaffic@gmail.com> * Fix linting * Add missing method from tablet notifications PR * No more maxlamp ref troll * Add text2num wrap * Fixes some borg tablet bugs (#54339) fix: Borg tablets now correctly work when the borg is out of power (though you'll get no networking until you get that power issue sorted out). fix: Borgs that are synced to AIs can correctly view and print photos once more. Co-authored-by: zxaber <37497534+zxaber@users.noreply.github.com> Co-authored-by: Changelogs <action@github.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: MrPerson <spamtaffic@gmail.com>
…ontrol tablet program + silicons start with HUD on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#7351
About The Pull Request
Depends on #7338 - I will forcepush a rebased version without said commits when mergedPorts:
yes I have planned more PRs that even depend on this PR, please send help i am in dependency hell
Why It's Good For The Game
Borgs now have a more intuitive management system and have their own built in tablet (with limitations), it's a much better interface than verbs and also makes borgs better able to monitor the station / crew, and makes them more upgradeable via tablet apps.
There is never a case where someone really wants their HUD off, so it starts on by default now. No more roundstart button pressing!
Testing Photographs and Procedure
Screenshots&Videos
2022-07-23.21-31-47.mp4
Changelog
🆑
tweak: Borgs and AIs now start with their borgHUDs/siliconHUDs on by default.
add: Added tablets to cyborgs. Humans can install apps to it by using portable data disks from the Deluxe Silicate Selections vendor and inserting the data disk with programs uploaded to cyborgs.
add: Added a borg self-management app to integrated cyborg tablet.
del: Removed most Robot Commands verbs in favor of the app.
tweak: Some lesser-used elements on the cyborg HUD are now in the management app.
add: Cyborgs can now change their headlamp color using the integrated tablet flashlight
/:cl: