Skip to content

Enable CI #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Enable CI #2

merged 1 commit into from
Jan 28, 2025

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Jan 27, 2025

This PR allow to retrieve artifacts for native build x64:

https://github.com/SiliconLabsSoftware/unify-z-wave/actions/runs/12988635586

Next PR will add target build

@rzr rzr marked this pull request as draft January 27, 2025 12:30
rzr added a commit that referenced this pull request Jan 27, 2025
Make dev-gui optional

Build package

Disable devui building because not reproducible:

  TS2786: 'BrowserRouter' cannot be used as a JSX component.

I suspect a floating dep, since it is maintained outside,
let's assume it will be fixed in the upstream (UnifySDK)

Origin: #2
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr requested a review from silabs-aydogane January 27, 2025 12:45
@rzr
Copy link
Collaborator Author

rzr commented Jan 27, 2025

Those changes can also apply upstream let me try to get them in unify core to reduce divergence

Depends on:

SiliconLabs/UnifySDK#50

@rzr rzr marked this pull request as ready for review January 28, 2025 00:20
@rzr rzr requested a review from Thomasdjb January 28, 2025 08:39
@rzr
Copy link
Collaborator Author

rzr commented Jan 28, 2025

Some changes have been merged in core, expected to land:

https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0

@rzr
Copy link
Collaborator Author

rzr commented Jan 28, 2025

Let me check all changes if they are atomic and make sure nothing is missing

Sorry for noise

@rzr rzr changed the title build artifacts Enable CI Jan 28, 2025
@rzr rzr merged commit 18f8139 into main Jan 28, 2025
@rzr rzr deleted the review/2/main branch January 28, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants