Repository navigation
feat: rewrite core and daemon in Rust - #1927
Open
NicholaiVogel wants to merge 612 commits into
Open
NicholaiVogel wants to merge 612 commits into
NicholaiVogel wants to merge 612 commits into
Conversation
Collaborator
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Assisted-by: OpenAI Codex:gpt-6-luna
Assisted-by: OpenAI Codex:gpt-6-luna
NicholaiVogel
force-pushed
the
hermes/hermes-8629112f
branch
from
September 25, 2026 17:47
cb3cf78 to
6384eab
Compare
Assisted-by: OpenAI Codex:gpt-6-luna
Report uncertain registry publication when directory sync fails. Assisted-by: OpenAI Codex:gpt-6-luna
Assisted-by: Hermes Agent:openai-codex/gpt-6-luna-900k
NicholaiVogel
force-pushed
the
hermes/hermes-8629112f
branch
from
September 28, 2026 01:37
bdb29f5 to
b6d2a13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Continue the existing Signet core and daemon rewrite in Rust while preserving TypeScript-owned behavior. The PR remains in progress and is not being presented as complete or merge-ready.
Changes
Owner IPC outcome flow
Type
feat— new user-facing feature (bumps minor)fix— bug fixrefactor— restructure without behavior changechore— build, deps, config, docsperf— performance improvementtest— test coveragePackages affected
@signet/core@signet/daemon@signet/cli/ dashboard@signet/sdk@signet/connector-*@signet/webpredictorplatform/rust-core,platform/rust-daemon, native service scripts, and docsScreenshots
Not applicable: no production UI components changed.
Migration Notes (if applicable)
This adds no new TypeScript schema version. It reconciles only the supported legacy v79 boundary through the existing owner transaction; repeated startup is safe, and existing data/history is preserved. It is not a general repair for arbitrary migration-history gaps.
Testing
bun testpassesbun run typecheckpassesbun run lintpassesA1 source-tree verification (the follow-up commit changed only commit metadata; its source tree is unchanged):
cargo test --locked --manifest-path platform/rust-core/Cargo.toml --test legacy_schema_admission— 27 passed, 0 failed.cargo build --locked --manifest-path platform/rust-daemon/Cargo.toml --bin signet-daemon— passed.bun test platform/rust-daemon/owner-lifecycle.native.contract.test.ts— 6 passed, 78 assertions, against the native process contract.bun run biome check --staged— passed for the staged owner-lifecycle contract test.rustfmt --edition 2021 --check --config skip_children=true platform/rust-core/src/lib.rsandgit diff --check— passed.bun run typecheck— exited 2 in a fresh worktree with missing workspace build artifacts and connector/daemon diagnostics; it is not claimed as passing.AI disclosure
Assisted-bytags in commits)Notes
This rewrite remains incomplete. The last recorded shared-corpus inventory found 497 protected paths and 480 runnable entrypoints; that is a path inventory, not executed-case coverage. A complete identical TypeScript/Rust corpus run, source-matched packaged-artifact acceptance, installed-like runtime/platform/load coverage, and the remaining subsystem parity work are outstanding.
As of September 28, 2026, all 10 GitHub CodeQL/Analyze checks passed on exact head
b6d2a13acb2641445a00a206c84e4c6a4dedadd1. These are code-analysis checks, not full rewrite/parity CI. The PR base has advanced and GitHub currently marks the branch as dirty against the base. Rebase/integration and the full acceptance criteria remain outstanding before merge readiness.