Repository navigation
fix(sources): report durable removal success - #1911
Merged
Merged
Conversation
NicholaiVogel
force-pushed
the
hermes/hermes-3d16a3d3
branch
from
September 24, 2026 14:11
33f37ed to
261d28e
Compare
Assisted-by: Hermes:gpt-5.6-luna
Assisted-by: Hermes:gpt-5.6-luna
Assisted-by: Hermes:gpt-5.6-luna
Assisted-by: OpenAI Codex
Regenerate event-loop line diagnostics. Assisted-by: OpenAI Codex
Refresh line-derived DB site tokens and regenerate the event-loop inventory after rebasing onto current main. This updates audit metadata only; product behavior is unchanged. Assisted-by: Hermes:gpt-6-luna
Track daemon startup indexing alongside route runs so source deletion retains its lease until late writes have been purged. Drain tracked lifecycle telemetry before the final tombstone cleanup and wait for startup runs after closing the bridge. Assisted-by: Hermes:gpt-6-luna
Regenerate the source-site entries after rebasing onto current main. Assisted-by: Hermes:gpt-6-luna
NicholaiVogel
force-pushed
the
hermes/hermes-3d16a3d3
branch
from
September 24, 2026 18:06
261d28e to
a86ad97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source deletion could commit configuration removal before asynchronous source work and cleanup had finished, making a durable change appear incomplete or allowing a late indexer to write artifacts back after purge. This PR makes completion, retryable cleanup, and operation conflicts explicit while serializing source deletion against mutations and in-flight startup/route indexing.
Flow
Changes
cleanupPendingindicates an index run or cleanup marker is still being drained.Type
feat— new user-facing feature (bumps minor)fix— bug fixrefactor— restructure without behavior changechore— build, deps, config, docsperf— performance improvementtest— test coveragePackages affected
@signet/core@signet/daemon@signet/cli/ dashboard@signet/sdk@signet/connector-*@signet/webpredictorScreenshots
No dashboard markup, styling, or visual behavior changed; screenshots are not applicable.
Migration Notes (if applicable)
No database migrations were touched.
Testing
bun testpassesbun run typecheckpassesbun run lintpassesTested against running daemon
N/A
bun test platform/core/src/sources-config.test.ts platform/daemon/src/routes/import-routes.test.ts platform/daemon/src/routes/sources-routes.test.ts platform/daemon/src/routes/source-deletion-startup-race.test.ts platform/daemon/src/source-index-progress.test.ts platform/daemon/src/routes/transcript-import-routes.scope.test.ts platform/daemon/src/routes/hooks-routes.notifications.test.ts platform/daemon/src/session-recall-dedupe.test.ts— 118 passed, 0 failed.bun run build— passed.bun scripts/audit-event-loop-contract.ts— passed (809 inventory; 153 legacy DB sites; no violations).bun test scripts/audit-event-loop-contract.test.ts— 24 passed, 0 failed.bun run comments:check— passed.bun run typecheck— passed.bun run lint— exited 0 with existing repository warnings.bun run format:check— passed with existing large-file warnings.git diff --check— passed.The two assertions in
platform/daemon/src/transcript-import-bytes.test.tsare base-identical failures: cross-agent content expected 403/received 409, and cross-agent transcript export expected 403/received 200.bun scripts/doc-drift.tsalso exits 1 with byte-identical output on base and PR. No running-daemon manual test was performed. CI for the rebased head will be reported after publication.AI disclosure
Assisted-bytags in commits)Notes
The current PR remote head predates the rebase. CI for the rebased head is pending until the updated branch is pushed. No running-daemon manual test was performed.