Skip to content

Conversation

KEGustafsson
Copy link
Contributor

@KEGustafsson KEGustafsson commented Jun 11, 2025

New implementation to add authenticated WS devices description as a name to Dashboard.
This fixes issues that #1705 had related for non-admin use cases.

316239363-8801b7d2-3fb5-4aee-bfa6-cf21017d9f08

Question for fine tuning of this PR is, should ws devices data be part of SERVERSTATISTICS or PROVIDERSTATUS feed?
Current implementation is adding it to SERVERSTATISTICS in deltastats.ts. It could be changed to index.ts and part of PROVIDERSTATUS.

@KEGustafsson KEGustafsson changed the title feat: ws devices use description as a name instead of id feat: ws devices use description as a name instead of id on Dashboard Jun 12, 2025
@tkurki tkurki added the feature label Jun 21, 2025
Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works for authenticated devices, right? So reflect that in the title and description.

Like for non-authenticated server you can send data to the server with echo '{"updates":[{"values":[{"path":"navigation.speedOverGround","value":3.15}]}]}' | wscat 'ws://localhost:3000/signalk/v1/stream?subscribe=none'but all you'll see on the list is ws.

@KEGustafsson
Copy link
Contributor Author

KEGustafsson commented Jun 21, 2025

Websocket devices, which are listed in Security/Devices/Devices list are the ones that are impacted. If device has description then that is used, fallback id.
If non-authenticated serves does not populated this list, then there is no change to current situation.

I haven't checked how things look with non-authenticated server, but need to check that too.

Use case is mainly SensESP and similar sensor devices, which are listed there and produce data to server.

I'll update title and description to address this feature in more precisely.

@KEGustafsson KEGustafsson changed the title feat: ws devices use description as a name instead of id on Dashboard feat: use device description as name on Dashboard for authenticated WS devices, if available Jun 23, 2025
@KEGustafsson
Copy link
Contributor Author

Title and description updated to highlight that PR target is to show authenticated WS devices from Security / Devices list.

@tedenda
Copy link

tedenda commented Jul 26, 2025

This work may close #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants