Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I´ve discovered another small prerequisite for the implementation of EQL correlations (SigmaHQ/pySigma-backend-elasticsearch#121)
The correlation template that I´ve come up with currently looks like this
As the
{groupby}
is needed outside from the{aggregate}
, I´ve added it to theconvert_correlation_rule_from_template
just like the timespan parameter before, because I have not found a better way to do it...