Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for EQL Correlations #325

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

Mat0vu
Copy link
Contributor

@Mat0vu Mat0vu commented Feb 18, 2025

Hi,
I´ve discovered another small prerequisite for the implementation of EQL correlations (SigmaHQ/pySigma-backend-elasticsearch#121)

The correlation template that I´ve come up with currently looks like this

default_correlation_query: ClassVar[str] = {
        "sequence": "sequence {groupby} with maxspan={timespan} \n {search} {aggregate} {condition}",
}

As the {groupby} is needed outside from the {aggregate}, I´ve added it to the convert_correlation_rule_from_template just like the timespan parameter before, because I have not found a better way to do it...

@Mat0vu
Copy link
Contributor Author

Mat0vu commented Feb 18, 2025

In my fork all tests were successful, the failed tests look like there was a temporary network issue, however I cannot find the option to rerun actions within this PR...

@thomaspatzke thomaspatzke merged commit f9d2f18 into SigmaHQ:main Feb 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants