WIP: conversion/base

SigmaHQ · Feb 16, 2025 · 39a9a7b · 39a9a7b
1 parent 4fd44ab
commit 39a9a7b
Show file tree

Hide file tree

Showing 5 changed files with 284 additions and 153 deletions.
diff --git a/sigma/collection.py b/sigma/collection.py
@@ -94,7 +94,7 @@ def from_dicts(
         in the errors property individually for each Sigma rule and the whole SigmaCollection.
         """
         errors = []
-        parsed_rules = list()
+        parsed_rules: List[SigmaRuleBase] = list()
         prev_rule = None
         global_rule: NestedDict = dict()
 

diff --git a/sigma/conditions.py b/sigma/conditions.py
@@ -41,7 +41,7 @@ def parent_chain_condition_classes(self) -> List[Type["ConditionType"]]:
         """Only return list of parent chain condition classes which are boolean operators."""
         return [item for item in self.parent_chain_classes() if item.operator]
 
-    def parent_condition_chain_contains(self, cond_class: Type["ConditionType"]):
+    def parent_condition_chain_contains(self, cond_class: Type["ConditionType"]) -> bool:
         """Determines if the class cond_class is contained in parent condition class chain."""
         return cond_class in self.parent_chain_condition_classes()
 
@@ -295,4 +295,5 @@ def parsed(self):
     ConditionNOT,
     ConditionFieldEqualsValueExpression,
     ConditionValueExpression,
+    ConditionItem,
 ]