Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add option skip web #6736

Merged
merged 2 commits into from
Jan 3, 2025
Merged

chore: add option skip web #6736

merged 2 commits into from
Jan 3, 2025

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Dec 31, 2024

Fixes #6711


Important

Adds SkipWebFrontend option to conditionally skip web frontend initialization in the query service.

  • Behavior:
    • Adds SkipWebFrontend option to ServerOptions in server.go.
    • Modifies createPublicServer() in server.go to conditionally add web frontend based on SkipWebFrontend.
  • Flags:
    • Adds -skip-web-frontend flag in main.go to set SkipWebFrontend option.
  • Error Handling:
    • Updates error handling in main.go to account for skipWebFrontend when creating web instance.

This description was created by Ellipsis for d7bc1fa. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d7bc1fa in 22 seconds

More details
  • Looked at 66 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ee/query-service/main.go:152
  • Draft comment:
    The error check for signozweb.New should be adjusted to ensure that the error is only logged if skipWebFrontend is false. Consider restructuring the logic to avoid logging an error when skipWebFrontend is true.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. ee/query-service/app/server.go:387
  • Draft comment:
    The implementation correctly checks the SkipWebFrontend option to conditionally add the web frontend to the router, resolving the issue described.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly implements the option to skip the web frontend, addressing the issue described. No violations of the specified rules are found in the provided code.

Workflow ID: wflow_rf72v1DIkKQ17xj9


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@nityanandagohain
Copy link
Member

@grandwizard28 please request the changes that you mentioned in the call

@srikanthccv srikanthccv enabled auto-merge (squash) January 3, 2025 04:01
@srikanthccv srikanthccv merged commit 9feee6f into main Jan 3, 2025
16 checks passed
@srikanthccv srikanthccv deleted the add-opt branch January 3, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query service errors out requiring a frontend build folder
3 participants