Skip to content

Fix #89: Prevent 10-minute timeout in macOS smoke tests by running mvis ci with sudo#90

Merged
SickleFire merged 1 commit into
SickleFire:devfrom
Samanyu-dev:issue-89-macos-smoke-test
Jul 6, 2026
Merged

Fix #89: Prevent 10-minute timeout in macOS smoke tests by running mvis ci with sudo#90
SickleFire merged 1 commit into
SickleFire:devfrom
Samanyu-dev:issue-89-macos-smoke-test

Conversation

@Samanyu-dev

Copy link
Copy Markdown
Collaborator

Description

On macOS, inspecting the memory of another process using task_for_pid requires root (sudo) privileges unless the process has a specific debugger entitlement. Because mvis ci was running without sudo, macOS was blocking it and triggering a headless "Developer Tools Access" interactive prompt asking for authentication. Since it's a headless CI environment with no user to click the prompt, the step was silently hanging until a 10-minute timeout occurred.

This PR updates action.yml to automatically prefix mvis ci with sudo when running on macOS (GitHub Actions macOS runners are configured with passwordless sudo), allowing the tests to complete successfully and quickly. Fixes #89.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Chore / Refactor

Related issues

How Has This Been Tested

  • Manual steps: Checked the workflow files and verified that prefixing sudo resolves the permission prompt hang on macOS runners.
  • Platform tested on: macOS (GitHub Actions Runner)

Checklist

  • I have read the CONTRIBUTING.md and followed the repo guidelines.
  • Code builds locally (cargo build --release)
  • All tests pass (cargo test)
  • New and existing tests cover my changes
  • I added/updated documentation where applicable
  • I updated CHANGELOG or release notes if needed

CI and Performance Notes

  • CI status: The action-smoke-test job for macOS should now pass quickly without timing out after 10 minutes.
  • Performance impact: No negative impact. This will significantly speed up the CI pipeline duration since it eliminates the 10-minute timeout hang.

Screenshots or Logs

(Not applicable)

Release Notes

  • Release type: patch
  • Notes for release manager: Fixed a CI timeout issue on macOS runners where action.yml would hang for 10 minutes due to missing sudo privileges for memory inspection.

@Samanyu-dev Samanyu-dev requested a review from SickleFire July 6, 2026 13:14
@Samanyu-dev Samanyu-dev self-assigned this Jul 6, 2026
Copilot AI review requested due to automatic review settings July 6, 2026 13:14
@Samanyu-dev Samanyu-dev added the bug Something isn't working label Jul 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@SickleFire SickleFire merged commit d5419e2 into SickleFire:dev Jul 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants