Fix - org id mismatch in org statistics #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frikky
reviewed
Sep 30, 2025
|
|
||
| if stats.OrgId != orgId { | ||
| log.Printf("[WARNING] Org stats data corruption detected. Fixing org stats for org %s (was %s)", orgId, stats.OrgId) | ||
| stats.OrgId = orgId |
There was a problem hiding this comment.
If orgId is empty somehow, this causes a recursive failure due to SetOrgStatistics() calling GetOrgStatistics() in that case. Would cause self-DOS.
Why isn't this fix in SetOrgStatistics() instead of in Get()? Makes little sense to me
There was a problem hiding this comment.
We aren't calling setOrgStatistics() to update the stats we are using transaction and updating directly to "org_statistics". Let me add check for the org id length check so, it won't cause any recursive failure issue.
There was a problem hiding this comment.
I still think it will, and will call you at 3AM the day it happens 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.