Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure winId is carried over to the pushed context #131

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

kyoh86
Copy link
Contributor

@kyoh86 kyoh86 commented Dec 18, 2024

Issue

When calling ddu.vim's start function with push=true, the context.winId is incorrectly set to the winId of an already open ddu.vim instance. This results in the return window selection being incorrect after closing the ddu.vim window.

Fix

To address this issue, the winId is now carried over from the previous ddu context when push=true. This ensures that the context.winId remains consistent with the previously opened ddu instance, allowing the return window to be selected correctly.

Verification

Tests and verifications have been conducted to ensure that the winId is correctly carried over and that the return window selection works as expected.

:new
:wincmd j
:call ddu#start(...)
:call ddu#ui#do_action("chooseAction")
:q
:q

@Shougo Shougo merged commit bde0ebb into Shougo:main Dec 19, 2024
2 checks passed
@Shougo
Copy link
Owner

Shougo commented Dec 19, 2024

OK. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants