Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to client-side routing in App Bridge nav menu for better UX an… #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Switch to client-side routing in App Bridge nav menu for better UX an…
…d loading speed
  • Loading branch information
siakaramalegos authored Jan 17, 2025
commit 91af39e2ec7cb12cefa8623537c0a4d081c0bb7c
6 changes: 3 additions & 3 deletions App.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BrowserRouter } from "react-router-dom";
import { BrowserRouter, Link } from "react-router-dom";
import { useTranslation } from "react-i18next";
import { NavMenu } from "@shopify/app-bridge-react";
import Routes from "./Routes";
@@ -18,8 +18,8 @@ export default function App() {
<BrowserRouter>
<QueryProvider>
<NavMenu>
<a href="/" rel="home" />
<a href="/pagename">{t("NavigationMenu.pageName")}</a>
<Link to="/" rel="home" />
<Link to="/pagename">{t("NavigationMenu.pageName")}</a>
</NavMenu>
<Routes pages={pages} />
</QueryProvider>
Loading