Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Moving ShopifyCli::Helpers::PartnersAPI to ShopifyCli::PartnersAPI #508

Merged
merged 7 commits into from
Apr 14, 2020
Merged

Moving ShopifyCli::Helpers::PartnersAPI to ShopifyCli::PartnersAPI #508

merged 7 commits into from
Apr 14, 2020

Conversation

mkevinosullivan
Copy link
Contributor

@mkevinosullivan mkevinosullivan commented Apr 9, 2020 •
edited
Loading

WHY are these changes introduced?

WHAT is this pull request doing?

  • moving lib/shopify-cli/helpers/partners_api.rb to lib/shopify-cli/partners_api.rb
  • moving test/shopify-cli/helpers/partners_api_test.rb to test/shopify-cli/partners_api_test.rb
  • changing references of Helpers::PartnersAPI to ShopifyCli::PartnersAPI in impacted helpers and tasks
  • changing autoload from lib/shopify-cli/helpers.rb to lib/shopify_cli.rb

Notes

  • Marked [WIP] Work In Progress as testing of commands that use the impacted helpers and tasks has yet to be completed

@mkevinosullivan mkevinosullivan requested a review from a team as a code owner April 9, 2020 00:29
ayronshopify
ayronshopify approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@ayronshopify ayronshopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚒

@mkevinosullivan
Copy link
Contributor Author

Tophat testing (to validate that PartnersAPI works correctly after code changes)

  • start in a non-app directory
  • shopify create rails - correctly authenticates against Partners login
  • log out again
  • shopify serve - correctly authenticates against Partners login
  • mv .env .env.old to prep for next command
  • shopify connect - correctly authenticates against Partners login
    • Issue: the connect command does not populate the SHOP= line, like create does
  • update .env with SHOP= line
  • shopify authenticate shop - correctly authenticates against the shop
  • shopify authenticate identity - correct re-authenticates against Partners login
    • Issue: if logged out, will launch browser tab to authenticate against partner login, THEN prompt to re-authenticate appears from CLI.
  • change out of app directory to a non-app directory
  • shopify create node - correctly authenticates against Partners login
  • log out again
  • shopify serve - correctly authenticates against Partners login
  • mv .env .env.old to prep for next command
  • shopify connect - correctly authenticates against Partners login
    • Issue: the connect command does not populate the SHOP= line, like create does
  • update .env with SHOP= line
  • shopify authenticate shop - correctly authenticates against the shop
  • shopify authenticate identity - correct re-authenticates against Partners login
    • Issue: if logged out, will launch browser tab to authenticate against partner login, THEN prompt to re-authenticate appears from CLI.

@mkevinosullivan mkevinosullivan changed the title [WIP] Moving ShopifyCli::Helpers::PartnersAPI to ShopifyCli::PartnersAPI Moving ShopifyCli::Helpers::PartnersAPI to ShopifyCli::PartnersAPI Apr 9, 2020
@tanema tanema force-pushed the shopify_cli_v2_feature branch from d71d601 to 1f1b0e6 Compare April 13, 2020 19:25
@tanema
Copy link
Contributor

tanema commented Apr 13, 2020

Sorry, you will have to rebase because I rebased the feature branch and there was a change to the partners API.

@mkevinosullivan
Move functionality from Helpers::OS over to
0ac3546 
Context, refactor the remaining code accordingly,
delete Helpers::OS and update test cases as needed.
@mkevinosullivan
Moving ShopifyCli::Helpers::PartnersAPI to
40da8cd 
ShopifyCli::PartnersAPI
- moving lib/shopify-cli/helpers/partners_api.rb to
  lib/shopify-cli/partners_api.rb
- moving test/shopify-cli/helpers/partners_api_test.rb to
  test/shopify-cli/partners_api_test.rb
- changing references of Helpers::PartnersAPI to ShopifyCli::PartnersAPI
  in impacted helpers and tasks
- changing autoload from lib/shopify-cli/helpers.rb to
  lib/shopify_cli.rb
@mkevinosullivan
Moving ShopifyCli::Helpers::PartnersAPI to
1c2a848 
ShopifyCli::PartnersAPI
- moving lib/shopify-cli/helpers/partners_api.rb to
  lib/shopify-cli/partners_api.rb
- moving test/shopify-cli/helpers/partners_api_test.rb to
  test/shopify-cli/partners_api_test.rb
- changing references of Helpers::PartnersAPI to ShopifyCli::PartnersAPI
  in impacted helpers and tasks
- changing autoload from lib/shopify-cli/helpers.rb to
  lib/shopify_cli.rb
@mkevinosullivan
Corrected output strings (spelling, grammar)
95bdbaf
@mkevinosullivan
Updating test case related to last commit
5d6dd3f
@mkevinosullivan mkevinosullivan force-pushed the partnersapi-from-helpers-to-shopifycli branch from 30a85dd to 5d6dd3f Compare April 13, 2020 21:55
@mkevinosullivan mkevinosullivan merged commit 1a7c267 into shopify_cli_v2_feature Apr 14, 2020
@tanema tanema deleted the partnersapi-from-helpers-to-shopifycli branch April 14, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tanema tanema tanema approved these changes

@ayronshopify ayronshopify ayronshopify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkevinosullivan @tanema @ayronshopify