Adds SQLite database for QR codes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
force-pushed
the
kos/add_sqlite_db
branch
from
aafcc4e to
b2e5c21
Compare
paulomarg
reviewed
May 16, 2022
qr-code/node/.gitignore
Outdated
| @@ -25,3 +25,6 @@ dist/ | |||
| # Without this, they may get a warning if using a different package manager to us | |||
| yarn.lock | |||
| package-lock.json | |||
|
|
|||
| # FIXUP: temporarily ignore shopify-cli toml file | |||
| shopify.app.toml | |||
There was a problem hiding this comment.
I wonder if we shouldn't just not ignore this and be ok with it popping up in PRs (not having it will make it tricky for new people to try out the app).
There was a problem hiding this comment.
And routinely overwrite it?
There was a problem hiding this comment.
Yeah it's not a great trade-off 😅 - which is better, constantly overwrite this or breaking it for other folks?
mkevinosullivan
force-pushed
the
kos/add_sqlite_db
branch
from
b2e5c21 to
afe02a9
Compare
Also renames database.sqlite to session_db.sqlite (for session storage)
mkevinosullivan
force-pushed
the
kos/add_sqlite_db
branch
from
afe02a9 to
7495347
Compare
paulomarg
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
database.sqlitetosession_db.sqlite(for session storage)shopify.app.tomlas it will change frequently during development