Get make yjit-bindgen to work on clean checkout. Fix miniruby build #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding miniruby as a prerequisite, `make yjit-bindgen` works right after a fresh `configure` run. This allows simplifying the instruction for running the command a bit in yjit/README.md. Tested with `make distclean` and a fresh `configure` run. Lots of warnings when building miniruby we will fix as we prune more C YJIT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding miniruby as a prerequisite,
make yjit-bindgenworks rightafter a fresh
configurerun. This allows simplifying the instructionfor running the command a bit in yjit/README.md.
Tested with
make distcleanand a freshconfigurerun.Lots of warnings when building miniruby we will fix as we prune more C
YJIT.