Skip to content

Bump @shopify/eslint-plugin from 41.3.1 to 48.0.2 #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 24, 2025

Bumps @shopify/eslint-plugin from 41.3.1 to 48.0.2.

Release notes

Sourced from @​shopify/eslint-plugin's releases.

@​shopify/eslint-plugin@​48.0.2

Patch Changes

@​shopify/eslint-plugin@​48.0.0

Major Changes

@​shopify/eslint-plugin@​47.0.1

Patch Changes

  • #461 b1b449c Thanks @​BPScott! - Add @typescript-eslint/no-unused-expressions to typescript ruleset

    In v46 in, we enabled no-unused-expressions in the core js config, then disabled it and replaced it with @babel/no-unused-expressions in esnext config. In typescript files we turn off no-unused-expressions but left @babel/no-unused-expressions enabled - which seems like an oversight given that @typescript-eslint/no-unused-expressions existed. In v47.0.0 we removed configuration of @babel/no-unused-expressions entirely, which meant that there was no linting of unused-expressions. This change brings back unused expression linting to typescript files.

@​shopify/eslint-plugin@​47.0.0

Major Changes

  • #444 75fe8da Thanks @​BPScott! - Replace eslint-plugin-node with eslint-plugin-n

  • #445 f1e02bc Thanks @​BPScott! - Update plugin dependencies

    • eslint-plugin-import: ^2.29.0to ^2.31.0
    • eslint-plugin-jest: ^28.5.0to ^28.9.0
    • eslint-plugin-jsx-a11y: 6.8.0 to 6.10.2
    • eslint-plugin-prettier: ^5.1.3to^5.2.1
    • eslint-plugin-promise: ^6.1.1to^7.2.1
    • eslint-plugin-react: ^7.34.1to^7.37.2
    • eslint-plugin-react-hooks: ^4.6.2to^5.1.0
    • eslint-plugin-sort-class-members: ^1.20.0 to ^1.21.0
  • #457 ef24642 Thanks @​BPScott! - Update typescript-eslint from ^7.9.0 to ^8.18.0. Replace usage of the @typescript-eslint/eslint-plugin and @typescript-eslint/eslint-parser packages with using the new typescript-eslint package. See migration information at https://typescript-eslint.io/blog/announcing-typescript-eslint-v8.

    The @typescript-eslint/ban-types rule has been removed and replaced with @typescript-eslint/no-empty-object-type and @typescript-eslint/no-wrapper-object-types. @typescript-eslint/no-require-imports is now enabled.

  • #455 e347da8 Thanks @​BPScott! - Remove configuration of deprecated formatting rules.

    Per https://eslint.org/blog/2023/10/deprecating-formatting-rules/ and https://typescript-eslint.io/blog/deprecating-formatting-rules several formatting related rules have been deprecated from eslint core and typescript-eslint and moved into @stylistic/eslint-plugin. These rules are removed in typescript-eslint v8 (released) and probably eslint v10 (unreleased).

    To prepare for future updates we are removing our configuration of these rules. We recommend that you use Prettier (https://prettier.io/) for formatting considerations - either by running it in parallel with ESLint or as part of ESLint through using eslint-plugin-prettier via the prettier config provided by @shopify/eslint-plugin. If you do not wish to use Prettier, then we suggest you configure rules from @stylistic/eslint-plugin (https://eslint.style/packages/default).

    Note that if you already use the prettier config then this removal will have no effect as all these rules were already turned off.

    Configuration for the following rules in the es5, esnext and typescript configs have been removed:

    From typescript-eslint:

    • @​typescript-eslint/brace-style

... (truncated)

Changelog

Sourced from @​shopify/eslint-plugin's changelog.

48.0.2

Patch Changes

48.0.0

Major Changes

47.0.1

Patch Changes

  • #461 b1b449c Thanks @​BPScott! - Add @typescript-eslint/no-unused-expressions to typescript ruleset

    In v46 in, we enabled no-unused-expressions in the core js config, then disabled it and replaced it with @babel/no-unused-expressions in esnext config. In typescript files we turn off no-unused-expressions but left @babel/no-unused-expressions enabled - which seems like an oversight given that @typescript-eslint/no-unused-expressions existed. In v47.0.0 we removed configuration of @babel/no-unused-expressions entirely, which meant that there was no linting of unused-expressions. This change brings back unused expression linting to typescript files.

47.0.0

Major Changes

  • #444 75fe8da Thanks @​BPScott! - Replace eslint-plugin-node with eslint-plugin-n

  • #445 f1e02bc Thanks @​BPScott! - Update plugin dependencies

    • eslint-plugin-import: ^2.29.0to ^2.31.0
    • eslint-plugin-jest: ^28.5.0to ^28.9.0
    • eslint-plugin-jsx-a11y: 6.8.0 to 6.10.2
    • eslint-plugin-prettier: ^5.1.3to^5.2.1
    • eslint-plugin-promise: ^6.1.1to^7.2.1
    • eslint-plugin-react: ^7.34.1to^7.37.2
    • eslint-plugin-react-hooks: ^4.6.2to^5.1.0
    • eslint-plugin-sort-class-members: ^1.20.0 to ^1.21.0
  • #457 ef24642 Thanks @​BPScott! - Update typescript-eslint from ^7.9.0 to ^8.18.0. Replace usage of the @typescript-eslint/eslint-plugin and @typescript-eslint/eslint-parser packages with using the new typescript-eslint package. See migration information at https://typescript-eslint.io/blog/announcing-typescript-eslint-v8.

    The @typescript-eslint/ban-types rule has been removed and replaced with @typescript-eslint/no-empty-object-type and @typescript-eslint/no-wrapper-object-types. @typescript-eslint/no-require-imports is now enabled.

  • #455 e347da8 Thanks @​BPScott! - Remove configuration of deprecated formatting rules.

    Per https://eslint.org/blog/2023/10/deprecating-formatting-rules/ and https://typescript-eslint.io/blog/deprecating-formatting-rules several formatting related rules have been deprecated from eslint core and typescript-eslint and moved into @stylistic/eslint-plugin. These rules are removed in typescript-eslint v8 (released) and probably eslint v10 (unreleased).

    To prepare for future updates we are removing our configuration of these rules. We recommend that you use Prettier (https://prettier.io/) for formatting considerations - either by running it in parallel with ESLint or as part of ESLint through using eslint-plugin-prettier via the prettier config provided by @shopify/eslint-plugin. If you do not wish to use Prettier, then we suggest you configure rules from @stylistic/eslint-plugin (https://eslint.style/packages/default).

    Note that if you already use the prettier config then this removal will have no effect as all these rules were already turned off.

    Configuration for the following rules in the es5, esnext and typescript configs have been removed:

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@shopify/eslint-plugin](https://github.com/Shopify/web-configs/tree/HEAD/packages/eslint-plugin) from 41.3.1 to 48.0.2.
- [Release notes](https://github.com/Shopify/web-configs/releases)
- [Changelog](https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/Shopify/web-configs/commits/@shopify/[email protected]/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@shopify/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 24, 2025
@dannbeau dannbeau closed this Apr 14, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 14, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/shopify/eslint-plugin-48.0.2 branch April 14, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant