Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
App Security has no SQL-injection agentic check. Existing XSS checks focus on DOM writes and specialized Shopify surfaces, leaving gaps in server-rendered app pages, templates, and hydration data.
WHAT is this pull request doing?
Add versioned SQL-injection and cross-site-scripting prompts that trace lower-trust input to executable sinks, verify defenses, and require concrete trust-boundary evidence. Incomplete paths remain unresolved; overlapping XSS findings stay with existing specialized checks.
Register both checks, regenerate the embedded prompts, extend the shipped check-ID contract tests, and add a minor changeset. These are agentic review prompts, not new deterministic detectors.
Local validation passed: engine tests, ESLint, CLI build, and a CLI review-pack/findings round trip. The 34-test check suite also passed after restoring the check-ID assertions. The smoke used hand-authored findings; model detection accuracy has not been evaluated.
How to manually test your changes?
Checklist