Add typed JSON output to theme preview - #8645
Draft
gonzaloriestra wants to merge 1 commit into
Draft
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8646
September 24, 2026 09:23
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:04
ebf024f to
fda3575
Compare
gonzaloriestra
removed this pull request from stack #8646
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
gonzalo/json-theme-open
to
gonzalo/json-theme-share
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:13
fda3575 to
f82379b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:25
f82379b to
f8f160d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 11:56
f8f160d to
781de0e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 13:46
781de0e to
a523b13
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 14:21
a523b13 to
571cd4e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 14:36
571cd4e to
814fcb9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme previewalready emits JSON, but its result has no discoverable schema and its service also renders output and opens the browser.Part of https://github.com/shop/issues-develop/issues/23695.
WHAT is this pull request doing?
Return a typed preview result and move presentation and browser opening into the command. Preserve the compact JSON keys, success messages, file/API errors, and nonfatal browser behavior. Browser failures use typed diagnostics in JSON mode.
Normal output:
Matching result:
{"url":"https://abc123.shopifypreview.com","preview_identifier":"abc123"}Compatibility decision: this draft preserves the existing stderr channel. During the full command lifecycle, the existing event context wraps that JSON string in an info diagnostic's
message; stdout stays empty. Moving the final result to stdout needs a separate compatibility decision. Tests capture both streams and cover the current behavior explicitly.Refresh the manifest, README, and generated docs. This PR reuses the output-capture helper from #8639.
How to manually test your changes?
Checklist