Fix shopify theme pull/push/package sync - #8632
Open
EvilGenius13 wants to merge 1 commit into
Open
EvilGenius13 wants to merge 1 commit into
EvilGenius13 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
no-changelog
karreiro
approved these changes
Sep 23, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add the required patch changeset, preserve deletion handling, and strengthen packaging regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Fixes theme pull, push, and package synchronization by excluding unsupported files.
Changes:
- Updates theme discovery, upload/delete ordering, and packaging patterns.
- Adjusts related tests and removes obsolete fixtures.
| File | Summary |
|---|---|
packages/theme/src/cli/utilities/theme-uploader.ts |
Updates synchronization ordering. |
packages/theme/src/cli/utilities/theme-uploader.test.ts |
Updates sync-order expectations. |
packages/theme/src/cli/utilities/theme-fs.ts |
Excludes unsupported files from discovery. |
packages/theme/src/cli/utilities/theme-fs.test.ts |
Updates filesystem and partition tests. |
packages/theme/src/cli/utilities/fixtures/theme/DESIGN.md |
Removes obsolete fixture. |
packages/theme/src/cli/utilities/fixtures/theme/config/styles.css |
Removes obsolete fixture. |
packages/theme/src/cli/utilities/fixtures/theme/AGENTS.md |
Removes obsolete fixture. |
packages/theme/src/cli/services/package.ts |
Updates package file patterns. |
packages/theme/src/cli/services/package.test.ts |
Updates packaging tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
8
to
9
| const themeFilesPattern = [ | ||
| 'AGENTS.md', | ||
| 'DESIGN.md', | ||
| 'assets/**', |
Comment on lines
31
to
33
| const THEME_DIRECTORY_PATTERNS = [ | ||
| 'AGENTS.md', | ||
| 'DESIGN.md', | ||
| 'assets/**/*.*', | ||
| 'config/**/*.json', |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
shopify theme pull/push/packagesync (porting patch released fix #8630)