Skip to content

Use vi.waitFor in app event watcher test #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfonso-noriega merged 1 commit into from
Jun 17, 2026
Merged

Use vi.waitFor in app event watcher test #7845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions packages/app/src/cli/services/dev/app-events/app-event-watcher.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,23 +383,17 @@ describe('app-event-watcher', () => {

await flushPromises()

// Wait until emitSpy has been called at least once
// We need this because there are I/O operations that make the test finish before the event is emitted
await new Promise<void>((resolve, reject) => {
const initialTime = Date.now()
const checkEmitSpy = () => {
// Wait until emitSpy has been called at least once.
// We need this because there are I/O operations that make the test finish before the event is emitted.
await vi.waitFor(
() => {
const allCalled = emitSpy.mock.calls.some((call) => call[0] === 'all')
const readyCalled = emitSpy.mock.calls.some((call) => call[0] === 'ready')
if (allCalled && readyCalled) {
resolve()
} else if (Date.now() - initialTime < 3000) {
setTimeout(checkEmitSpy, 100)
} else {
reject(new Error('Timeout waiting for emitSpy to be called'))
}
}
checkEmitSpy()
})
expect(allCalled).toBe(true)
expect(readyCalled).toBe(true)
},
{timeout: 3000, interval: 100},
)

expect(emitSpy).toHaveBeenCalledWith('all', {
app: expect.objectContaining({realExtensions: finalExtensions}),
Expand Down
Loading