Skip to content

Remove migrateLegacyFunctions #6111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 07-14-send_uuid_on_app_version_create_to_do_app_matching
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jul 15, 2025

WHY are these changes introduced?

This PR removes the legacy function migration code that is no longer needed.

WHAT is this pull request doing?

Removes the migrateLegacyFunctions function and its usage in the automaticMatchmaking function. This code was previously used to handle the migration of legacy functions by matching them with their new counterparts, but is no longer necessary.

How to test your changes?

  1. Run the CLI with a project that contains functions
  2. Verify that function identification and matching still works correctly

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jul 15, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan force-pushed the 07-15-remove_migratelegacyfunctions branch from 207dc02 to d650f9e Compare July 15, 2025 13:29
@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch from d3f1f29 to 5099ba9 Compare July 15, 2025 13:29
Copy link
Contributor

github-actions bot commented Jul 15, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.93% (-0.33% 🔻)
12978/16654
🟡 Branches
72.12% (-0.29% 🔻)
6336/8785
🟡 Functions
78.08% (-0.14% 🔻)
3366/4311
🟡 Lines
78.33% (-0.33% 🔻)
12290/15690
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / liquid-tag-content.ts
91.67% 75% 100% 91.67%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app.ts
86.24% (-0.53% 🔻)
68.22% (-2.8% 🔻)
93.44%
88.34% (-0.61% 🔻)
🟡
... / extension-instance.ts
78.13% (-7.08% 🔻)
74.29% (-7.97% 🔻)
91.07% (-1.52% 🔻)
77.53% (-7.63% 🔻)
🟢
... / patch-app-configuration-file.ts
93.33% (-6.67% 🔻)
100% (+20% 🔼)
85.71% (-14.29% 🔻)
93.33% (-6.67% 🔻)
🔴
... / extension.ts
56.45% (-1.88% 🔻)
60%
44.44% (-5.56% 🔻)
57.38% (-1.94% 🔻)
🟡
... / build.ts
71.74% (-7.97% 🔻)
58.7% (-4.35% 🔻)
69.05% (-4.76% 🔻)
70.77% (-7.69% 🔻)
🟢
... / common.ts
90.91% (+7.58% 🔼)
91.67% (+13.1% 🔼)
71.43% (-3.57% 🔻)
89.47% (+8.52% 🔼)
🔴
... / partners-client.ts
24.7% (-1.09% 🔻)
26.09% (-3.91% 🔻)
17.74% (-0.29% 🔻)
24.53% (-0.96% 🔻)
🟢
... / errors.ts
94.74% (-2.23% 🔻)
85.71% (-0.95% 🔻)
100%
94.74% (-2.23% 🔻)
🔴
... / theme-command.ts
38.78% (-4.62% 🔻)
12.5% (-6.73% 🔻)
40%
42.22% (-4.72% 🔻)
🟢
... / local-assets.ts
91.36% (-0.69% 🔻)
73.58% (-1.85% 🔻)
100%
93.51% (-0.54% 🔻)
🟢
... / server.ts
82.9% (-0.84% 🔻)
75.34% (-0.66% 🔻)
87.5% (-0.38% 🔻)
83.24% (-0.83% 🔻)

Test suite run success

3044 tests passing in 1314 suites.

Report generated by 🧪jest coverage report action from 46089a7

@isaacroldan isaacroldan force-pushed the 07-15-remove_migratelegacyfunctions branch from d650f9e to cde3ba4 Compare July 15, 2025 13:44
@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch 2 times, most recently from 0941461 to df98fb0 Compare July 16, 2025 08:16
@isaacroldan isaacroldan force-pushed the 07-15-remove_migratelegacyfunctions branch from cde3ba4 to b5ba43f Compare July 16, 2025 08:16
@isaacroldan isaacroldan marked this pull request as ready for review July 16, 2025 09:06
@isaacroldan isaacroldan requested a review from a team as a code owner July 16, 2025 09:06
@isaacroldan isaacroldan force-pushed the 07-15-remove_migratelegacyfunctions branch from b5ba43f to 46089a7 Compare July 21, 2025 09:41
@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch from df98fb0 to 7a09ce3 Compare July 21, 2025 09:41
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant