build(deps): bump the rust-dependencies group across 1 directory with 3 updates - #15
Conversation
… 3 updates Bumps the rust-dependencies group with 3 updates in the / directory: [base64](https://github.com/marshallpierce/rust-base64), [ureq](https://github.com/algesten/ureq) and [zip](https://github.com/zip-rs/zip2). Updates `base64` from 0.22.1 to 0.23.1 - [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md) - [Commits](marshallpierce/rust-base64@v0.22.1...v0.23.1) Updates `ureq` from 3.3.0 to 3.4.0 - [Changelog](https://github.com/algesten/ureq/blob/main/CHANGELOG.md) - [Commits](algesten/ureq@3.3.0...3.4.0) Updates `zip` from 6.0.0 to 8.6.0 - [Release notes](https://github.com/zip-rs/zip2/releases) - [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md) - [Commits](zip-rs/zip2@v6.0.0...v8.6.0) --- updated-dependencies: - dependency-name: base64 dependency-version: 0.23.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies - dependency-name: ureq dependency-version: 3.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust-dependencies - dependency-name: zip dependency-version: 8.6.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: rust-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
ShiroKSH
left a comment
There was a problem hiding this comment.
Author context: Dependabot automated maintenance bot; no human contributor history applicable.
Changes requested. Zip 8 changes data_start to return an optional offset, but the artifact validators still use it as a u64. The current head fails to compile in crates/rustferry-github/src/artifact.rs at lines 943 and 1788, artifact_offline.rs at lines 606 and 610, and artifact_store.rs at line 783. CI, platform artifacts, and the Linux extension fixture all fail as a result.
Keep the Zip dependency on the compatible major version, or update every archive validation path to reject a missing offset as an invalid archive and add coverage for that case. These validators form part of the untrusted-archive boundary, so an unwrap or default value would not be an acceptable migration.
ShiroKSH
left a comment
There was a problem hiding this comment.
Approved. The follow-up handles the optional Zip 8 data offset before archive-range arithmetic, mapping an unavailable offset to the existing invalid-archive errors. That preserves fail-closed behavior at the untrusted-archive boundary. The affected crate passed its all-features check and 339 unit tests locally.
ShiroKSH
left a comment
There was a problem hiding this comment.
Approved. The follow-up regenerates the reviewed Cargo dependency inventory for the new lockfile. The complete license check passes with the refreshed inventory.
Bumps the rust-dependencies group with 3 updates in the / directory: base64, ureq and zip.
Updates
base64from 0.22.1 to 0.23.1Changelog
Sourced from base64's changelog.
Commits
069bf70v0.23.16ab1fb0Merge pull request #310 from musicinmybrain/test-on-non-simd-arches7cffce6Fix testing on architectures without unsafe SIMD supporte34f9a0Merge pull request #308 from atouchet/come9240c9Remove outdated comment9e9220av0.23.0870326eMerge pull request #306 from marshallpierce/mp/trailing-bits-docsfbec5f1Document no trailing trailing bits0a23549Merge pull request #305 from marshallpierce/mp/edition-2021f10b7e2Update deps & editionUpdates
ureqfrom 3.3.0 to 3.4.0Changelog
Sourced from ureq's changelog.
Commits
5e803fc3.4.082b37b5Update changelog for 3.4.007b8ea2Seal RequestExt (#1189)0df28a1Update changelog653e963Bump deps (#1188)830f6cachore: remove redundant clone (#1187)6e9a050Send CONNECT Proxy-Authorization scheme as canonical "Basic" (#1185)f8a5bedFix TLS to targets through HTTPS proxies (#1183)1f1c342Support testing in release mode (#1180)089c235Update rustls-platform-verifier to 0.7.0Updates
zipfrom 6.0.0 to 8.6.0Release notes
Sourced from zip's releases.
... (truncated)
Changelog
Sourced from zip's changelog.
... (truncated)
Commits
771dfc5chore: release v8.6.0 (#781)8e480ccchore(deps): update sha1 requirement from 0.10 to 0.11 (#767)2513bbechore(deps): update aes requirement from 0.8 to 0.9 (#787)957e240ci(deps): bump actions/cache from 5.0.4 to 5.0.5 (#786)0329d9dfix: allow for[u8]as filename (#775)ddcf854ci(deps): bump github/codeql-action from 4.35.1 to 4.35.2 (#788)42323a8ci(deps): bump actions/create-github-app-token from 3.0.0 to 3.1.1 (#785)901014aci(deps): bump crate-ci/typos from 1.45.0 to 1.45.1 (#784)07702d4feat: addcompression not supportedas enum error (#774)2d0c46bci(deps): bump actions/upload-artifact from 7.0.0 to 7.0.1 (#783)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions