DEV-557 Updating USB bus reported device descriptions #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds four new functions to generate USB device identification strings for the SHIMMER3R platform. These functions create descriptive device names that incorporate MAC ID suffixes and device type information for USB Mass Storage, CDC ACM, and Composite Device interfaces.
Key changes:
- Added four new USB device ID generation functions conditionally compiled for SHIMMER3R
- Each function generates a custom USB device string combining "Shimmer" prefix with last 4 MAC ID characters and device type
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| log_and_stream_common.h | Declares four new USB device ID generation functions under SHIMMER3R conditional compilation |
| log_and_stream_common.c | Implements the four USB device ID generation functions with sprintf-based string formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.