DEV-475 moving some sampling timer code to common and tidying #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the data sampling and streaming architecture by renaming functions and constants to better reflect their purpose, and extracts ISR logic into a separate timer-triggered function.
- Renamed
TASK_STREAMDATAtoTASK_GATHER_DATAandShimSens_streamData()toShimSens_gatherData()for clarity - Extracted ISR logic into new
ShimSens_sampleTimerTriggered()function - Introduced
platform_gatherData()API for platform-specific data gathering customization - Changed state transition from
SAMPLING_COMPLETEtoSAMPLE_NOT_READYinShimSens_saveData()
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TaskList/shimmer_taskList.h | Renamed task enum constant from TASK_STREAMDATA to TASK_GATHER_DATA |
| TaskList/shimmer_taskList.c | Updated switch case to use renamed task constant and function |
| Sensing/shimmer_sensing.h | Renamed function declaration and replaced ISR function with timer-triggered function |
| Sensing/shimmer_sensing.c | Renamed data gathering function, refactored ISR into timer function, changed state assignment |
| SDCard/shimmer_sd_cfg_file.c | Updated task constant reference in configuration read function |
| Platform/platform_api.h | Added new weak function declaration for platform-specific data gathering |
| Platform/platform_api.c | Implemented default weak function for platform-specific data gathering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 1d6507a.
…himmerResearch/log-and-stream-common.git into DEV-475_stability_improvements
Base automatically changed from
DEV-543_MCU_to_PC_SD_handover_for_mac
to
main
November 27, 2025 08:26
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.