1267 remove feedback feature #1348

Vainakh · 2024-05-13T00:31:27Z

No description provided.

richardxia

Thanks for submitting this! There are a few more places where you need to remove references to the feedback feature, but this otherwise looks great to me!

richardxia · 2024-05-14T04:31:23Z

app/pages/OrganizationListingPage.tsx

@@ -60,9 +58,6 @@ export const OrganizationListingPage = () => {
  );


On the lines just above this, could you remove the "feedback" string from both arrays? I can't comment directly on the lines, since they're just beyond the range of what the GitHub interface allows me to comment on, but they're just above this line.

richardxia · 2024-05-14T04:31:45Z

app/pages/ServiceListingPage.tsx

@@ -66,9 +64,6 @@ export const ServiceListingPage = () => {
  );


Similar comment about removing "feedback" on the lines above this.

richardxia · 2024-05-14T04:33:27Z

app/components/listing/FeedbackModal.tsx

-    className="feedback__Modal"
-    overlayClassName="feedback__Overlay"


These are CSS classes that are actually still defined in their corresponding CSS file. Could you remove the following lines here?

askdarcel-web/app/components/listing/ActionBar.scss

Lines 39 to 71 in f6db93a

.feedback__Overlay {

position: fixed;

top: 0;

left: 0;

right: 0;

bottom: 0;

background-color: rgba(94, 94, 94, 0.6);

overflow: auto;

}

.feedback__Modal {

position: absolute;

margin: 0 auto;

top: 20%;

left: 0;

right: 0;

width: 570px;

padding: 34px 46px;

background-color: $color-white;

box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25);

border-radius: 10px;

@media screen and (max-width: 767px) {

top: 5%;

width: 100%;

height: 95%;

padding: 40px 25px;

}

}

.feedback-modal {

display: none;

}

…Page.tsx abd ServiceListingPage.tsx. Remove feedback form related classnames from ActionBar.scss.

richardxia

Thanks for making this change! This PR LGTM now. Our usual process is that once a PR has been approved, the submitter is the one who hits the merge button, so feel free to do that at your leisure.

Vainakh · 2024-05-14T20:06:59Z

Richard, Hitting that merge button felt good! Looking forward to many more hits or buttons :) whichever it may be! Thank you!

…

On Tue, May 14, 2024 at 1:57 PM Richard Xia ***@***.***> wrote: ***@***.**** approved this pull request. Thanks for making this change! This PR LGTM now. Our usual process is that once a PR has been approved, the submitter is the one who hits the merge button, so feel free to do that at your leisure. — Reply to this email directly, view it on GitHub <#1348 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKJ4DB3PLCGWVBLD4EPMIVTZCJUBJAVCNFSM6AAAAABHTHL6R6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJWGI4DMMJSGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Vainakh · 2024-05-17T11:06:53Z

Hi Richard, Should I start working on any other ticket? Thanks! On Tue, May 14, 2024 at 2:06 PM Adlan Yandarbiev ***@***.***> wrote:

…

Richard, Hitting that merge button felt good! Looking forward to many more hits or buttons :) whichever it may be! Thank you! On Tue, May 14, 2024 at 1:57 PM Richard Xia ***@***.***> wrote: > ***@***.**** approved this pull request. > > Thanks for making this change! This PR LGTM now. Our usual process is > that once a PR has been approved, the submitter is the one who hits the > merge button, so feel free to do that at your leisure. > > — > Reply to this email directly, view it on GitHub > <#1348 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AKJ4DB3PLCGWVBLD4EPMIVTZCJUBJAVCNFSM6AAAAABHTHL6R6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJWGI4DMMJSGM> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

schroerbrian · 2024-05-17T17:16:42Z

Thanks for your contribution, Adlan! I think this ticket would be a good one for you to tackle: #1313

Vainakh · 2024-05-18T17:03:44Z

Brian, Looking good! Thank you!

…

On Fri, May 17, 2024 at 11:17 AM Brian Schroer ***@***.***> wrote: Thanks for your contribution, Adlan! I think this ticket would be a good one for you to tackle: #1313 <#1313> — Reply to this email directly, view it on GitHub <#1348 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKJ4DB2PVE7XQWX5ZWE2NXDZCY3RBAVCNFSM6AAAAABHTHL6R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGA2DCNZTGE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

Vainakh added 2 commits May 12, 2024 18:27

#1267 Remove Feedback Feature

95da1c3

#1267 Add back className

d0d629a

Vainakh assigned richardxia, schroerbrian, lgarofalo and davidagustin May 13, 2024

Vainakh added 5 commits May 12, 2024 18:37

#1267 Remove import references

9b1e845

#1267 Remove import references in addition

f8f4fb3

#1267 Replace import statement in ServiceListingPage.tsx

db0bc1f

#1267 Remove unused references in the components.

a3a06d1

#1267 remove remaining modal code

6baf34b

richardxia reviewed May 14, 2024

View reviewed changes

#1267 Remove all references of string feedback in OrganizationListing…

df60455

…Page.tsx abd ServiceListingPage.tsx. Remove feedback form related classnames from ActionBar.scss.

richardxia approved these changes May 14, 2024

View reviewed changes

Vainakh merged commit 56b1ddf into master May 14, 2024
5 checks passed

Vainakh deleted the 1267-remove-feedback-feature branch May 14, 2024 20:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1267 remove feedback feature #1348

1267 remove feedback feature #1348

Vainakh commented May 13, 2024

richardxia left a comment

richardxia May 14, 2024

richardxia May 14, 2024

richardxia May 14, 2024

richardxia left a comment

Vainakh commented May 14, 2024 via email

Vainakh commented May 17, 2024 via email

schroerbrian commented May 17, 2024

Vainakh commented May 18, 2024 via email

		@@ -60,9 +58,6 @@ export const OrganizationListingPage = () => {
		);

		@@ -66,9 +64,6 @@ export const ServiceListingPage = () => {
		);

		className="feedback__Modal"
		overlayClassName="feedback__Overlay"


	.feedback__Overlay {
	position: fixed;
	top: 0;
	left: 0;
	right: 0;
	bottom: 0;
	background-color: rgba(94, 94, 94, 0.6);
	overflow: auto;
	}

	.feedback__Modal {
	position: absolute;
	margin: 0 auto;
	top: 20%;
	left: 0;
	right: 0;
	width: 570px;
	padding: 34px 46px;
	background-color: $color-white;
	box-shadow: 0 3px 6px rgba(0, 0, 0, 0.25);
	border-radius: 10px;
	@media screen and (max-width: 767px) {
	top: 5%;
	width: 100%;
	height: 95%;
	padding: 40px 25px;
	}
	}

	.feedback-modal {
	display: none;
	}

1267 remove feedback feature #1348

1267 remove feedback feature #1348

Conversation

Vainakh commented May 13, 2024

richardxia left a comment

Choose a reason for hiding this comment

richardxia May 14, 2024

Choose a reason for hiding this comment

richardxia May 14, 2024

Choose a reason for hiding this comment

richardxia May 14, 2024

Choose a reason for hiding this comment

richardxia left a comment

Choose a reason for hiding this comment

Vainakh commented May 14, 2024 via email

Vainakh commented May 17, 2024 via email

schroerbrian commented May 17, 2024

Vainakh commented May 18, 2024 via email