Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logging.debug output that may contain PII for production push #935

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jeffbl
Copy link
Member

@jeffbl jeffbl commented Dec 19, 2024

Until #912 is fixed, we do not want to risk PII going into logs. This removes several logging.debug lines from content-categoriser and graphic-caption preprocessors, to be reinstated once #912 is completed.

Tested on several photos to make sure nothing else appears to be leaking, and that commenting out these lines didn't introduce any issues.

Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!

Don't delete below this line.


Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue.
  • I described how I tested these changes.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@jeffbl jeffbl self-assigned this Dec 19, 2024
@jeffbl jeffbl merged commit 00be321 into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant