Refactor text box margins #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the text box margin functionality by extracting the margin calculations into a dedicated TextBoxMargins class and updating its usage across the code. Key changes include:
- Creation of a new TextBoxMargins class encapsulating left, right, top, and bottom margin logic.
- Refactoring of the TextBox class and related classes (ShapeCollection, IParagraph, and GroupedShapeCollection) to use the new margins class.
- Minor formatting improvements in multiline expressions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Texts/TextBoxMargins.cs | Introduces a new class to encapsulate margin properties. |
| src/Texts/TextBox.cs | Delegates margin handling to TextBoxMargins and adjusts constructor. |
| src/Shapes/ShapeCollection.cs, | Updates creation of TextBox instances to pass the new margins instance. |
| src/Paragraphs/IParagraph.cs, | Updates TextBox instantiation to use the refactored margins approach. |
| src/Groups/GroupedShapeCollection.cs | Updates TextBox instantiation accordingly. |
Comments suppressed due to low confidence (1)
src/Texts/TextBox.cs:381
- [nitpick] Consider consolidating the newWidth calculation onto a single line or adjusting the indentation for the multiline expression to enhance readability.
var newWidth =
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.