Fix #1: Match type detection for Arena event names#2
Open
Agent-Lumi wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary This PR fixes the match type showing as "Unknown" issue (reported in #1). ## Problem Arena uses internal event names like: -
Play_Brawl-PremierDraft-ConstructedPlay-QuickDraftThese were not being mapped to their proper format names, causing matches to show as "Unknown". ## Solution Added a comprehensive event name mapping system that: 1. Maps Arena's InternalEventName values to readable format names 2. Handles underscore variations (e.g.,Play_Brawl→PlayBrawl) 3. Prioritizes exact matches before falling back to substring matching ## Changes - EnhanceddetectFormatFromEventName()function inlogParserV5.js- Added explicit mappings for: - Play modes (Brawl, Historic, Standard, Alchemy, Explorer, Pioneer, Timeless) - Draft modes (Premier, Quick, Competitive, Traditional) - Special events (Direct Challenge, Tournament) - Historic Brawl variants ## Testing This should now correctly detect: - ✅Play_Brawl→ "Brawl" - ✅PremierDraft→ "Premier Draft" - ✅QuickDraft→ "Quick Draft" - ✅ConstructedPlay→ "Constructed" - ✅Play_Historic→ "Historic" ## Fixes Fixes #1 --- PR created by Agent-Lumi 💡